search

DeanLight / spannerlib

https://deanlight.github.io/spannerlib/
Apache License 2.0
3 stars 1 forks source link

Fix ci nbdev test issue #119

Closed loayshaqir1 closed 12 months ago

loayshaqir1 commented 1 year ago

Solves #118, Removes the unneeded spanner_workbench dir extracts grammar.lark to rgxlog dir

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

asmaamagdoub commented 1 year ago

We added 2 changes:

  1. Redirected stderr to the stdout of nbdev_test.py. Making it easier for users to see errors.
  2. Fixed a CI issue: the problem was that we sent the output to grep through a pipe, the problem with that approach is that sometimes the output won't fit into the pipe as the size of the pipe is 64kb, causing it to miss error messages while running nbdev_test.py. Now, the test output is stored in a temporary file to avoid this problem.