Moving to nbdev - Githubissues

DeanLight / spannerlib

https://deanlight.github.io/spannerlib/

Apache License 2.0

3 stars 1 forks source link

Moving to nbdev #91

Closed loayshaqir1 closed 1 year ago

loayshaqir1 commented 1 year ago

These files contains the original code of the spanner workbench just moved to notebooks, they still might have some documentations edited and / or more comments than the original version. So these will be our base files before all the PRs

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

loayshaqir1 commented 1 year ago

We have addressed all the changes you requested on this PR. This PR is ready to get merged to master, the only thing left is to merge the Add Tests PR but i don't think that we need to wait for that to get ready, Asmaa can merge the tests immediately to master after she takes care of the changes you requested

DeanLight commented 1 year ago

In our conversation we talked about:

solving CI bug with


if __name__ == 'rgxlog':
magic_session = Session()



* getting rid of 2 setup.py and just having the external 1
* putting the grammar.lark file not inside its own directory