fixing silent bug in the fixed_point function related to 'thresh' parameter

DeanLight / spannerlib

https://deanlight.github.io/spannerlib/

Apache License 2.0

3 stars 1 forks source link

fixing silent bug in the fixed_point function related to 'thresh' parameter #94

Closed asmaamagdoub closed 1 year ago

asmaamagdoub commented 1 year ago

This is a silent bug because we are calling the 'fixed_point' function with 'thresh' set to 0: bound_free_vars = fixed_point(start=set(), step=get_bound_free_vars, distance=get_size_difference, thresh=0) However, it's important to note that the 'fixed_point' function was not designed to handle 'thresh' values below 0

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.