DeanWay / fastapi-versioning

api versioning for fastapi web applications
MIT License
650 stars 63 forks source link

Replaced deprecated openapi_prefix for root_path. #22

Closed synchronizing closed 3 years ago

synchronizing commented 4 years ago

Fixes the following annoying warning:

"openapi_prefix" has been deprecated in favor of "root_path", which follows more closely the ASGI standard, is simpler, and more automatic. Check the docs at https://fastapi.tiangolo.com/advanced/sub-applications/

Fixes #13.

synchronizing commented 3 years ago

@DeanWay If you don't mind to take a quick look at this, it would be appreciated. Small bug fix, and a simple one line changer.

DeanWay commented 3 years ago

@synchronizing Thanks fo your PR, looks like this will need an accompanying change of requiring fastapi >= 0.56.0. As that appears to be the version where root_path was introduced

DeanWay commented 3 years ago

I will apply that, and create a release for this

DeanWay commented 3 years ago

@synchronizing this is released in version 0.6.0

synchronizing commented 3 years ago

@DeanWay Thank you for taking your time, much appreciated!