DeathShadez / Substratum

A Terra pack that creates a completely underground world with several unique caves to explore within.
GNU General Public License v3.0
8 stars 2 forks source link

Exception during pack initialitation #3

Closed null-shadow closed 3 months ago

null-shadow commented 3 months ago

Server software: Paper (1.20.1 #196) Plugins used: Terra, Spark Version of Terra: v6.3.1-BETA+73baaec6c Addons installed:

I tried to merge the cave biomes of Substratum into the Overworld Pack (default Terra Pack), and the server throws this exception:

[13:38:47] [Server thread/INFO]: [com.dfsek.terra.registry.master.ConfigRegistry] Loading ZIP archive: default.zip [13:38:48] [Server thread/WARN]: [com.dfsek.terra.event.FunctionalEventHandlerImpl] Exception occurred during event handling. Report this to the maintainers of terra@1.0.0 java.lang.RuntimeException: java.lang.RuntimeException: Failed to load script "structures/substratum/place_water.tesf" at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] at java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562) ~[?:?] at java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:591) ~[?:?] at java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:689) ~[?:?] at java.util.stream.Nodes.collect(Nodes.java:328) ~[?:?] at java.util.stream.ReferencePipeline.evaluateToNode(ReferencePipeline.java:111) ~[?:?] at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:570) ~[?:?] at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260) ~[?:?] at java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616) ~[?:?] at java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:622) ~[?:?] at java.util.stream.ReferencePipeline.toList(ReferencePipeline.java:627) ~[?:?] at com.dfsek.terra.addons.terrascript.TerraScriptAddon.lambda$initialize$1(TerraScriptAddon.java:57) ~[?:?] at com.dfsek.terra.config.fileloaders.LoaderImpl.thenEntries(LoaderImpl.java:49) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.addons.terrascript.TerraScriptAddon.lambda$initialize$2(TerraScriptAddon.java:40) ~[?:?] at com.dfsek.terra.event.EventContextImpl.lambda$handle$0(EventContextImpl.java:50) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?] at com.dfsek.terra.event.EventContextImpl.handle(EventContextImpl.java:50) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.event.FunctionalEventHandlerImpl.lambda$handle$0(FunctionalEventHandlerImpl.java:52) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?] at com.dfsek.terra.event.FunctionalEventHandlerImpl.handle(FunctionalEventHandlerImpl.java:48) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.event.EventManagerImpl.lambda$callEvent$0(EventManagerImpl.java:38) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at java.util.HashMap$Values.forEach(HashMap.java:1065) ~[?:?] at com.dfsek.terra.event.EventManagerImpl.callEvent(EventManagerImpl.java:38) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.config.pack.ConfigPackImpl.(ConfigPackImpl.java:174) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.config.pack.ConfigPackImpl.(ConfigPackImpl.java:135) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.registry.master.ConfigRegistry.load(ConfigRegistry.java:77) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.registry.master.ConfigRegistry.loadAll(ConfigRegistry.java:67) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.AbstractPlatform.lambda$load$0(AbstractPlatform.java:152) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.event.EventContextImpl.lambda$handle$0(EventContextImpl.java:50) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?] at com.dfsek.terra.event.EventContextImpl.handle(EventContextImpl.java:50) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.event.FunctionalEventHandlerImpl.lambda$handle$0(FunctionalEventHandlerImpl.java:55) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?] at com.dfsek.terra.event.FunctionalEventHandlerImpl.handle(FunctionalEventHandlerImpl.java:48) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.event.EventManagerImpl.lambda$callEvent$0(EventManagerImpl.java:38) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at java.util.HashMap$Values.forEach(HashMap.java:1065) ~[?:?] at com.dfsek.terra.event.EventManagerImpl.callEvent(EventManagerImpl.java:38) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at com.dfsek.terra.bukkit.TerraBukkitPlugin.onEnable(TerraBukkitPlugin.java:59) ~[Terra-bukkit-6.3.1-BETA+73baaec6c-shaded.jar:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:281) ~[paper-api-1.20.1-R0.1-SNAPSHOT.jar:?] at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:189) ~[paper-1.20.1.jar:git-Paper-196] at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:104) ~[paper-1.20.1.jar:git-Paper-196] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507) ~[paper-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20_R1.CraftServer.enablePlugin(CraftServer.java:642) ~[paper-1.20.1.jar:git-Paper-196] at org.bukkit.craftbukkit.v1_20_R1.CraftServer.enablePlugins(CraftServer.java:553) ~[paper-1.20.1.jar:git-Paper-196] at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:274) ~[paper-1.20.1.jar:git-Paper-196] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1100) ~[paper-1.20.1.jar:git-Paper-196] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) ~[paper-1.20.1.jar:git-Paper-196] at java.lang.Thread.run(Thread.java:842) ~[?:?] Caused by: java.lang.RuntimeException: Failed to load script "structures/substratum/place_water.tesf" at com.dfsek.terra.addons.terrascript.TerraScriptAddon.lambda$initialize$0(TerraScriptAddon.java:54) ~[?:?] at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?] at java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1850) ~[?:?] at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?] at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?] at java.util.stream.Nodes$CollectorTask.doLeaf(Nodes.java:2183) ~[?:?] at java.util.stream.Nodes$CollectorTask.doLeaf(Nodes.java:2149) ~[?:?] at java.util.stream.AbstractTask.compute(AbstractTask.java:327) ~[?:?] at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754) ~[?:?] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] Caused by: com.dfsek.terra.addons.terrascript.parser.exceptions.ParseException: Unexpected argument at position 5 in function block: 23:7 at com.dfsek.terra.addons.terrascript.parser.Parser.parseFunction(Parser.java:450) ~[?:?] at com.dfsek.terra.addons.terrascript.parser.Parser.parseItem(Parser.java:385) ~[?:?] at com.dfsek.terra.addons.terrascript.parser.Parser.parseBlock(Parser.java:362) ~[?:?] at com.dfsek.terra.addons.terrascript.parser.Parser.parse(Parser.java:96) ~[?:?] at com.dfsek.terra.addons.terrascript.script.StructureScript.(StructureScript.java:127) ~[?:?] at com.dfsek.terra.addons.terrascript.TerraScriptAddon.lambda$initialize$0(TerraScriptAddon.java:52) ~[?:?] at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?] at java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1850) ~[?:?] at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?] at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?] at java.util.stream.Nodes$CollectorTask.doLeaf(Nodes.java:2183) ~[?:?] at java.util.stream.Nodes$CollectorTask.doLeaf(Nodes.java:2149) ~[?:?] at java.util.stream.AbstractTask.compute(AbstractTask.java:327) ~[?:?] at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754) ~[?:?] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] [13:38:48] [Server thread/INFO]: [com.dfsek.terra.bukkit.nms.v1_20_R1.AwfulBukkitHacks] Hacking biome registry... [13:38:48] [Server thread/INFO]: [com.dfsek.terra.bukkit.nms.v1_20_R1.AwfulBukkitHacks] Doing tag garbage....

Then, the pack does not load when I try to use it as a generator, or when I type /packs. Maybe is happening something with the place_water.tesf script? I don't know.

DeathShadez commented 3 months ago

Seems like the 1.20.1 version of Terra didn't have the terrascript block physics argument at the time. You could possibly backport the addon for this feature, but the place_water feature is disabled by default anyways. You can just go this line https://github.com/DeathShadez/Substratum/blob/main/structures/substratum/place_water.tesf#L23 and replace it with block(0, 0, 0, "minecraft:water", false);

null-shadow commented 3 months ago

Yeah, it works. Thanks a lot.

DeathShadez commented 3 months ago

No problem.