search

DebDebMN / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

Summary #5

Open Tooconfident opened 7 years ago

Tooconfident commented 7 years ago

Grade: Meets Expectations

Good job with this project. I really didn't have any major criticism or preferences on changing your decisions. I really liked your choices and you show a solid knowledge of flex and other complex css properties like z-index. You will see my line issue's are more commentary on alternative solutions to your style choices. Whether you think they are better or helpful is up to you. I hope you find them nice options to clean things up and make it DRY(Don't Repeat Yourself). Start looking into media queries for responsive design websites. You are totally ready for making your website mobile friendly and getting a head start on that will help you going forward. Great work!

https://css-tricks.com/snippets/css/media-queries-for-standard-devices/

DebDebMN commented 7 years ago

Thank you very much for your great suggestions and good review.

BTW - In 39 years of coding, I've never looked back at code I've written without noticing better or cleaner ways of doing things. I guess it's just the nature of our wonderful profession!