Debangan202Ok / Data-Structure

This project aims to demonstrate various data structures using Vite.js, Tailwind CSS, React. Contributions are welcome! If you have new ideas or improvements, please feel free to share them with me.
https://data-structure-skill.netlify.app/
14 stars 22 forks source link

UI Changes #19

Closed sohamtembhurne closed 9 months ago

sohamtembhurne commented 9 months ago

This is the fix for issue #4. Do take a look and a feedback would be great!

netlify[bot] commented 9 months ago

Deploy Preview for data-structure-skill ready!

Name Link
Latest commit cd23ebcad9ab60cef09822ea342de482094a8e25
Latest deploy log https://app.netlify.com/sites/data-structure-skill/deploys/651f077c258d1700083f6a48
Deploy Preview https://deploy-preview-19--data-structure-skill.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Debangan202Ok commented 9 months ago

This is the fix for issue #4. Do take a look and a feedback would be great!

@sohamtembhurne can you make the animation transition little bit smooth while scrolling?

sohamtembhurne commented 9 months ago

Do you have any particular type of transition in mind?

Debangan202Ok commented 9 months ago

Do you have any particular type of transition in mind?

hey @sohamtembhurne 1.i would like you to take a look at the animation on the GreenSock website (https://greensock.com/gsap/). 2.Concerning the layout of containers:

i want each container to occupy one viewport, and you want each container to automatically stay centered when scrolling.

sohamtembhurne commented 9 months ago

I made the transitions smoother.

Debangan202Ok commented 9 months ago

I made the transitions smoother.

@sohamtembhurne it's look fabulous. Can you make all the container same size? Screenshot_20231005_195731_Brave.jpg

sohamtembhurne commented 9 months ago

Fixed, you can merge the PR if there aren't any more changes

Debangan202Ok commented 9 months ago

Fixed, you can merge the PR if there aren't any more changes

@sohamtembhurne look at this deploy-preview-19--data-structure-skill netlify app_

i think you have to add some margins and use the responsive breakpoints for control the margin flow in different view ports

sohamtembhurne commented 9 months ago

This is happening for smaller screens due to not similiar text context. Let me try to find a fix.

Debangan202Ok commented 9 months ago

This is happening for smaller screens due to not similiar text context. Let me try to find a fix.

You can use breakpoint classes for larger devices margin will be increase and for Smaller devices as it is.i would like to Recommend you to use developer tools on your browser. Bcuz this website want to be responsive for different devices at any scale.

sohamtembhurne commented 9 months ago

I have committed the changes you suggested

Debangan202Ok commented 9 months ago

I have committed the changes you suggested

Screenshot_20231006_003132_Brave.jpg

Look at this in lab section.

sohamtembhurne commented 9 months ago

This issue is due to the new sidebar functionality added, changes need to be done with the new button.

sohamtembhurne commented 9 months ago

This issue is due to the new sidebar functionality added, changes need to be done with the new button.

Do add the hacktoberfest-accepted label