Debangan202Ok / Data-Structure

This project aims to demonstrate various data structures using Vite.js, Tailwind CSS, React. Contributions are welcome! If you have new ideas or improvements, please feel free to share them with me.
https://data-structure-skill.netlify.app/
14 stars 22 forks source link

Added a side navigation bar feature for data structures labs #21

Closed Miran-Firdausi closed 9 months ago

Miran-Firdausi commented 9 months ago

As of now its a responsive sidebar UI element as new data structure will be added, we can set the routes and links.

netlify[bot] commented 9 months ago

Deploy Preview for data-structure-skill ready!

Name Link
Latest commit a4931592bcf274c252562e09a49964ffdf852f5d
Latest deploy log https://app.netlify.com/sites/data-structure-skill/deploys/651ef2aacd9b150008397b4d
Deploy Preview https://deploy-preview-21--data-structure-skill.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Debangan202Ok commented 9 months ago

@Miran-Firdausi please try to keep responsive in different view ports. deploy-preview-21--data-structure-skill netlify app_labs_ (1) try to align the icon with the proper container position. it's look ugly now

deploy-preview-21--data-structure-skill netlify app_labs_

look at the operation area. please fix it.

Miran-Firdausi commented 9 months ago

what exactly you want me to do, I didn't get it?

Debangan202Ok commented 9 months ago

what exactly you want me to do, I didn't get it?

look at the sidenav icon which not proper align in mobile devices and also look the stack operation container which shrinking badly with different view ports.

most of the container have border radius also so try to add border radius in the sidenav icon

Miran-Firdausi commented 9 months ago

image You are talking about hamburger icon, right? Can you suggest me idea how to place it. or where to place it. Cause there is already a hamburger for navigating home and labs section. and stack operation is not as wide as how it works div, right? I will fix it.

Debangan202Ok commented 9 months ago

image You are talking about hamburger icon, right? Can you suggest me idea how to place it. or where to place it. Cause there is already a hamburger for navigating home and labs section. and stack operation is not as wide as how it works div, right? I will fix it.

try to align the icon with the starting position of the stack operation container. use developer tools to debug and fix the responsiveness and don't forget add border radius. it may be help you.

Miran-Firdausi commented 9 months ago

sure, got it...

Miran-Firdausi commented 9 months ago

Check now. Tell me if anything else needs to be changed.

Debangan202Ok commented 9 months ago

sure, got it...

@Miran-Firdausi nice work. But i think it need more enhancement. If you wanna done with the current changes tell me. So i will merge it for now.

Miran-Firdausi commented 9 months ago

Merge as of now. Will do more later.

Debangan202Ok commented 9 months ago

Check now. Tell me if anything else needs to be changed.

Screenshot_20231005_230953_Brave.jpg

Look at this it's not properly align with the container.

Miran-Firdausi commented 9 months ago

image You want to align with this border, right?

Debangan202Ok commented 9 months ago

Merge as of now. Will do more later.

Ahh!well. Doing this for now.

Debangan202Ok commented 9 months ago

image You want to align with this border, right?

Yes! Catched

Miran-Firdausi commented 9 months ago

will do that...

Debangan202Ok commented 9 months ago

@Miran-Firdausi thank you for contribution. Don't forget to give a start on this repo😊.

Miran-Firdausi commented 9 months ago

Your welcome. Starred. Please add hactoberfest-accepted label.

Debangan202Ok commented 9 months ago

Your welcome. Starred. Please add hactoberfest-accepted label.

Sure.