Peer-to-peer code review

[rbreva]

Peer-to-peer code review

Looks great

• Maybe it colud bo improved if the data is reordered
• You can use .sort sort((a, b) => b.score - a.score)

[didierganthier]

Hi @DebbyMiressa, Your project is complete! There is nothing else to say other than... great work :shipit: Congratulations! 🎉

Highlights

• The Pull Request has a proper title and description. ✔️
• You have added a descriptive Readme file. Good Job. ✔️
• There is no linter error is present. ✔️
• Project has met all the technical aspects you needed for this project. Keep rocking! ✔️

Optional suggestions

• [ ] In order to follow JavaScript best practices I would suggest not using keywords such as GET or POST to name your class considering that these are HTTP methods:
  • https://github.com/DebbyMiressa/Leaderboard/blob/985eec0cce6dddade13476f69bf82efd47d0b383/src/getData.js#L1
  • https://github.com/DebbyMiressa/Leaderboard/blob/985eec0cce6dddade13476f69bf82efd47d0b383/src/postData.js#L1

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.