search

Debian / debiman

debiman generates a static manpage HTML repository out of a Debian archive
Apache License 2.0
191 stars 46 forks source link

brace at the end of the link #121

Closed 532910 closed 4 years ago

532910 commented 4 years ago

https://manpages.debian.org/unstable/slapd/slapd.plugin.5.en.html points to http://www.openldap.org/doc/admin/)) but the correct link is without brace at the end:http://www.openldap.org/doc/admin/

slapd.plugin.5:

.SH SEE ALSO 
.BR slapd (8),
.LP
"OpenLDAP Administrator's Guide" (http://www.OpenLDAP.org/doc/admin/)
.SH ACKNOWLEDGEMENTS
.so ../Project
532910 commented 4 years ago

https://www.openldap.org/software/man.cgi?query=slapd.plugin renders it correctly

stapelberg commented 4 years ago

https://github.com/Debian/debiman/blob/fc8252157877b4f57b1598fe2e7d1a5cbe438e7f/internal/convert/convert.go#L158 is where we find xrefs and URLs. The code should be updated to exclude ) (and probably others, but I don’t have an exhaustive list handy) from URLs.

Let me know if you want to send a PR which changes the code (and the corresponding test)

stapelberg commented 4 years ago

I deployed a new version with the fix and started a re-render of the entire archive.

It’ll be a while before it’s done and live, though: expect pages to be fixed within the next few days.