Debian / debiman

debiman generates a static manpage HTML repository out of a Debian archive
Apache License 2.0
189 stars 46 forks source link

assets/style.css: deemphasize panels #60

Open nmartensen opened 7 years ago

nmartensen commented 7 years ago

The panels with links, table of contents, other versions/languages/sections dominate the visual appearance of the manpage display: They use graphical elements (white text on red background), a large font size, and on wide screens are located close to the center of the screen. This distracts from the actual manpage content.

With this pull request I'd like to propose a few small changes:

What do you think?

(And while I am here: Thank you for the new manpages.debian.org service. This is absolutely fantastic.)

stapelberg commented 7 years ago

Thanks for the pull request. I can’t test it right now, so a before/after screenshot would be helpful for the discussion.

Note that the design was copied from the Debian package tracker, and I’d like to keep it consistent with the package tracker and other Debian properties. We can make small adjustments where they make sense, but in general, we shouldn’t deviate too much.

nmartensen commented 7 years ago

Before:

man_d_o-original

After:

man_d_o-modified

nmartensen commented 7 years ago

Yes, the similarity in style to the package tracker is immediately recognizable. It just takes the focus away from the manpage text (IMHO). The style works for the tracker since it does not have any plain text main section.

The proposed style update makes this more similar to packages.debian.org (example: https://packages.debian.org/unstable/bash)

stapelberg commented 7 years ago

Thanks for providing the screenshot, that helps.

I understand your argument, but personally, I still prefer the panels as they are, mainly for consistency with the tracker.

It’s unfortunate that Debian doesn’t yethave enough web properties with shared elements to establish a consistent design language. Maybe we can ask Kalle Söderman (contact details at https://nm.debian.org/public/process/13089) for advice on how to reconcile our two different points of view? He seems to be the main driver behind the current design, see https://wiki.debian.org/KallesDesign.

As a stop-gap (or permanent, depending on how this discussion concludes) solution, consider using a user style sheet. See http://superuser.com/a/319322/108037

nmartensen commented 7 years ago

Well, the tracker does not (yet?) follow Kalle's design? Feel free to ask him, I'm not going to insist on anything :)

bdrung commented 7 years ago

I like the proposed change. The panels visual dominate the page, especially when they are not on the right side. The design from packages.debian.org (example: https://packages.debian.org/unstable/bash) would be better than the one from tracker.debian.org IMHO.