search

Debian / raspi3-image-spec

contains the files to build the https://wiki.debian.org/RaspberryPi3 image
127 stars 32 forks source link

rpi3-resizerootfs: Support non mmc devices for initial resize #16

Closed nicman23 closed 6 years ago

stapelberg commented 6 years ago

Before I merge, can you update the commit message from “update rpi3-resizerootfs” to something conveying the intention behind the change please? E.g. “support all kinds of storage (e.g. USB)”.

nicman23 commented 6 years ago

done

stapelberg commented 6 years ago

You changed the pull request title. Please change the commit message, too, as that’s what ends up in the git history (and hence in “git blame” output, for example).

nicman23 commented 6 years ago

sorry, fixed, i do not use github ui that much

stapelberg commented 6 years ago

On https://github.com/Debian/raspi3-image-spec/pull/16/commits, I still see the old commit message.

If you prefer the command-line, see “view command line instructions”, then use git commit --amend (or interactive rebase) and force-push afterwards.

Or, if it’s easier, you can also create a new pull request altogether :)

jlu5 commented 6 years ago

(If it helps speed this up, GitHub lets you squash+merge and override the commit message if enabled in repository settings: https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github)

gwolf commented 6 years ago

I am closing this pull request as we will most probably use the rewritten resizerootfs script instead.