Closed a3nm closed 6 years ago
Thanks for the PR!
By the way, one other thing that could maybe be documented is the fact that building the image fails mysteriously ("cannot run apt-key") if the user running the build has another umask that 022 (see here). I don't know whether you think it's a relevant point to document, but it's the main problem I had to debug when building the image. What do you think?
Yeah, we should definitely recommend env -i
and umask
until https://github.com/larswirzenius/vmdb2/issues/26 is fixed upstream. Feel free to put that into this very PR, or submit a different one.
I implemented your suggestion, thanks! As for the environment cleanup issue, I tried to explain how to do it, but with env -i
it's a bit ugly because you need to keep some variables. What do you think?
I'm running a build now to check that the proposed invocation works until the end; if it does work I'm fine with merging.
I did your suggested change, thanks! The build seems to run, just checking now that it actually completes.
Please let me know once you have a working image and I’ll merge. Thanks again!
Image creation completed successfully, so for me this can be merged. Thanks for reviewing and for coding this. :)
-- Antoine Amarilli Sent from a mobile device, please excuse brevity and top-posting.
On October 25, 2017 12:15:23 PM GMT+02:00, Michael Stapelberg notifications@github.com wrote:
Please let me know once you have a working image and I’ll merge. Thanks again!
Hi, this is as discussed in issue #1. I also documented the need to install the dependencies of vmdb2, if that's OK.
By the way, one other thing that could maybe be documented is the fact that building the image fails mysteriously ("cannot run apt-key") if the user running the build has another umask that 022 (see here). I don't know whether you think it's a relevant point to document, but it's the main problem I had to debug when building the image. What do you think?