search

Debian / raspi3-image-spec

contains the files to build the https://wiki.debian.org/RaspberryPi3 image
127 stars 32 forks source link

Revert "Fix the cmdline.txt options to boot by label, not by partition" #33

Closed chschlue closed 6 years ago

chschlue commented 6 years ago

This reverts commit 554020cc949be4803e83bd4bd9f1f76c2ad73d10.

This change wasn't functional, ${ROOT?} does not make sense in a chroot.

Also, I suggest fixing this in raspi3-firmware, cmdline.txt would get overwritten anyway on every kernel update.

gwolf commented 6 years ago

You are right about this. I have locally fixed it by removing the ${ROOT?}. I do not think this should go into raspi3-firmware, as not everybody will adhere to the partition naming scheme I chose here; I think people building their own raspberry layouts will expect things to boot from mmcblk0p1 - And will know where to look otherwise. Am currently building an image (as you know, the process is far from quick on spinning rust), and if all's well, I will push it today. Also, I am meaning to update the raspi3-firmware package Real Soon Now™, I just want to be sure of a couple of things before messing it up.

chschlue commented 6 years ago

Ok, but if raspi3-firmware overwrites cmdline.txt over and over, what's the point?

chschlue commented 6 years ago

This way, if you boot from USB and update your kernel some time later you're screwed and left with an unbootable system.

gwolf commented 6 years ago

Ok, but if raspi3-firmware overwrites cmdline.txt over and over, what's the point?

Then that is clearly a bug! Users should be able to change their partitioning layouts without expecting the system to die. That's something that should be either configurable or detected at install time.

gwolf commented 6 years ago

@chschlue, seems you are always a step ahead of me :smile:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903543

chschlue commented 6 years ago

Gunnar Wolf notifications@github.com schrieb am Do., 23. Aug. 2018, 16:20:

@chschlue https://github.com/chschlue, seems you are always a step ahead of me 😄

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903543

Finally, my prayers are heard 😀