Open dekideian opened 3 years ago
Opened a PR https://github.com/DeborahK/Angular-NgRx-GettingStarted/pull/52 :). Realized I can fork the repo and then I can push a branch and open a PR.
Hi
You rock for taking the time to point this out!
I agree with you in a more real-world example you would guard for this. I would love to accept a PR to fix it and you are kind to offer but we strive to keep the code and the video in sync. For this reason, I do not think we should change it until the next course update. I have tagged this issue to address when we do the next update.
Hello,
Really appreciate your work and your courses. Kudos! :)
Found a small bug, when all the products are removed, it is not possible to add a new one without explicitly mentioning an id. Have the fix on a separate branch ready for PR, cannot push it sadly, 403.
Best regards, Deian