search

DeborahK / Angular-NgRx-GettingStarted

Materials for our Pluralsight course: Angular NgRx: Getting Started: http://bit.ly/AngularNgRx.
MIT License
547 stars 722 forks source link

Toggle password not working? #62

Open yringler opened 1 year ago

yringler commented 1 year ago

This must be on me, but I don't see what I might be doing wrong. I did the "homework" for module 4, and the password wasn't becoming visible. Then I tried the original version - also not. Did something change in browser security recently? Checked firefox and chrome. I'm probably going to find tomorrow that I made a silly mistake, IDK.

yringler commented 1 year ago

So - despite the words "Mask USER NAME" being clearly in the UI, it never occurred to me that there would be an option to mask anything other than a password 😆 Would you take a PR to have the toggle work on the password field?

DeborahK commented 1 year ago

Glad you resolved the issue!

At this time, we want the code here to match what's covered in the course, so we aren't taking PRs.

We do update the course from time to time and will include your feedback.

Thanks for posting your resolution!