DebuggyTeam / architecture-extensions

A mod that allows you to make more detailed builds with all kinds of new building blocks and shapes.
MIT License
7 stars 9 forks source link

[Compat] Promenade #13

Open sisby-folk opened 2 years ago

sisby-folk commented 2 years ago

List the blocks you want added to AE.

List the blocktype(s) you want added to AE.

No response

What blocktypes do your block(s) fall under if applicable.

Describe how your blocktype(s) will work if applicable.

No response

Additional context

I mean hey, I saw both at blanketcon

I personally only use palm and cherry, and consider these more interesting as aurora's decorations has support for the wood types from these mods, however I thought I'd at least list out the others.

woodiertexas commented 2 years ago

When Arch-Ex gets runtime datagen as part of its rewrite, it'll be able to see what modded blocks exist and then generate Arch-Ex blocks for said modded blocks.

sisby-folk commented 2 years ago

oh rad

On Tue, 26 Jul 2022, 8:34 am woodiertexas, @.***> wrote:

When Arch-Ex gets runtime datagen as part of its rewrite, it'll be able to see what modded blocks exist and then generate Arch-Ex blocks for said modded blocks.

— Reply to this email directly, view it on GitHub https://github.com/woodiertexas/architecture-extensions/issues/13#issuecomment-1194721544, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ34KOWU6C7OJUVDIUNV73VV4I6TANCNFSM54RKPI6Q . You are receiving this because you authored the thread.Message ID: @.***>

woodiertexas commented 1 year ago

Since Arch-Ex 2 is released. It is possible to do mod compat via its API which is documented here: https://github.com/DebuggyTeam/architecture-extensions/wiki/Integrating-Arch-Ex-into-your-mod

I recommend talking to the dev(s) of Promenade about integrating Arch-Ex into the mod.

Optionally, you can join the Debuggycord server here: https://discord.gg/bWN57F5CCA

sisby-folk commented 1 year ago

I'd like this to be reopened.

Now - I don't still use promenade, but it's worth noting that prompting content mod devs to interface with archex2 api as the only route into things like wood and stone type compat completely locks out fabric mods from having arch-ex compatibility.

We're quilt mod developers and we like developing on the quilt toolchain - but that doesn't change that Promenade is a fabric mod, and has no ability to do this interfacing in its current state.

It would be possible for archex to ship an isModLoaded-style compatibility package for things like this and auroras deco and soul ice - but additionally, looking over the documentation for archex integration it seems like it could potentially be data driven instead?

Basically, a built-in compat package, making parts of the API data driven where possible, or both (how switchy does it), would resolve this issue.

falkreon commented 1 year ago

After discussing with the other devs I think it would be realistic to scan for json at a predefined path in each mod in order to "passively" pick up things like new wood types, one "base block" per json. That way it's clean, data driven, and if archex isn't around the json just gets ignored.

If that sounds like a satisfactory solution I'll get a PR started asap.