Clear Sky outfit names not correct => st_items_outfit.xml

[chatico]

Hi I noticed while trying to merge SRP v1.1.3, that the Clear Sky outfit name is not correct:

Original v1.1.3 code of the file "st_items_outfit.xml" starting at line 75

    <string id="csky_heavy_outfit_description">
        <text>Standard equipment used by Clear Sky assault squads. This body armor is able to stop a pistol bullet, while its integrated gas mask provides good protection from anomalous exposure. Includes a container capable of holding one artifact, and can be upgraded to hold up to three artifacts.</text>
    </string>
    <string id="csky_heavy_outfit_name">
        <text>CS-3a body armor</text>
    </string>
    <string id="csky_light_outfit_description">
        <text>This body armor was designed for conducting search operations in areas of low anomalous activity. Its higher quality materials result in greater durability. Includes a container capable of holding one artifact, and can be upgraded to hold up to three artifacts.</text>
    </string>
    <string id="csky_light_outfit_name">
        <text>CS-1 body armor</text>
    </string>

But the name needs to be swapped like this, to be correct.

    <string id="csky_heavy_outfit_description">
        <text>Standard equipment used by Clear Sky assault squads. This body armor is able to stop a pistol bullet, while its integrated gas mask provides good protection from anomalous exposure. Includes a container capable of holding one artifact, and can be upgraded to hold up to three artifacts.</text>
    </string>
    <string id="csky_heavy_outfit_name">
        <text>CS-1 body armor</text>
    </string>
    <string id="csky_light_outfit_description">
        <text>This body armor was designed for conducting search operations in areas of low anomalous activity. Its higher quality materials result in greater durability. Includes a container capable of holding one artifact, and can be upgraded to hold up to three artifacts.</text>
    </string>
    <string id="csky_light_outfit_name">
        <text>CS-3a body armor</text>
    </string>

[SurDno]

Actually, the strings in SRP 1.1.3 are correct.

[chatico]

You are correct. But in the latest commit of that file, those name strings are swapped.

https://github.com/Decane/SRP/blob/master/gamedata/configs/text/eng/st_items_outfit.xml

line 79 and line 85 needs to be swapped if I'm correct. Can you confirm this?

csky_heavy_outfit_name = > "CS-1 body armor" (but is "CS-3a body armor" on repo) csky_light_outfit_name => "CS-3a body armor" (but is "CS-1 body armor" on repo)

https://stalker.fandom.com/wiki/CS-1_body_armor https://stalker.fandom.com/wiki/CS-3a_body_armor_(Clear_Sky)

[SurDno]

First, the swap is going back to initial commit in 2017, which is SRP 1.1.2 upload.

Second, don't rely on wiki, it's very bad. The reason CS-3a has "(Clear Sky)" postfix there is because CS-3a suit in CoP and CS-1 in CS are one and the same. That's why SRP swaps them.

Finally, check the spreadsheet I linked earlier. The strings are swapped in Russian and Ukrainian original localizations, only English is wrong there. SRP simply corrects the mistranslation.

[chatico]

Oh ok right, I'm sorry for my confusion with it. Thanks for taking the time to explain.