search

Decane / SRP

Sky Reclamation Project for S.T.A.L.K.E.R.: Clear Sky
http://www.moddb.com/mods/srp
131 stars 21 forks source link

Make the 'Return to Yar' quest fail on daybreak to match the behaviour of 'Get the PDA' quest and Yar's description of it #99

Closed SurDno closed 4 years ago

SurDno commented 4 years ago

Fix for #7.

Decane commented 4 years ago

@SurDno Why has a spurious newline character been added to the end of each file? If it's your text editor doing that automatically, please configure it not to - it introduces a spurious diff into every file you edit that doesn't originally have a newline before end-of-file. (GSC did not consistently write POSIX-compliant text files.)

Your changes look otherwise sound.

SurDno commented 4 years ago

All of these pull requests have been done through GitHub online editor. I might switch to GitHub Desktop and some sort of local text editor.

SurDno commented 4 years ago

Yeah, I tried reimplementing the same change with Notepad++ and local GitHub Desktop and it worked perfectly, without end-of-the-line changes. I'll push these changes to 'yar' repository now.

Decane commented 4 years ago

Thanks - merged. :)

Just needs readme entries, but I'll handle those.

SurDno commented 4 years ago

Can you, if possible, port it to Decane/SRP-Lite as well?