Trigger manually? - Githubissues

jchannon commented 4 years ago

With the new action workflow_dispatch I can trigger actions manually. Is there a way to pass in a milestone number to the release notes generator action so it generates release notes? Obvioulsy I could re-open then close a milestone but....

mmornati commented 3 years ago

Hey. Sorry for the daly but that indeed a good idea. I'm working on it right now.

mmornati commented 3 years ago

PR ready and in review. All seems work. If you want to test it before the official release (need to wait for the review) you can doing it in this way:

on:
  milestone:
    types: [closed]
  workflow_dispatch:
    inputs:
      milestoneId:
        description: 'Milestone ID'     
        required: true
        default: '1'
name: Milestone Closure
jobs:
  release-notes:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@master
      - name: Create Release Notes
        uses: decathlon/release-notes-generator-action@feat_workflow_dispatch
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          OUTPUT_FOLDER: temp_release_notes
          USE_MILESTONE_TITLE: "true"

jchannon commented 3 years ago

Cool. Will take a look over the holidays

On Sat, 19 Dec 2020 at 14:30, Marco Mornati notifications@github.com wrote:

PR ready and in review. All seems work. If you want to test it before the official release (need to wait for the review) you can doing it in this way:

on: milestone: types: [closed] workflow_dispatch: inputs: milestoneId: description: 'Milestone ID' required: true default: '1' name: Milestone Closure jobs: release-notes: runs-on: ubuntu-latest steps:

uses: actions/checkout@master

name: Create Release Notes uses: decathlon/release-notes-generator-action@feat_workflow_dispatch env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} OUTPUT_FOLDER: temp_release_notes USE_MILESTONE_TITLE: "true"

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Decathlon/release-notes-generator-action/issues/14#issuecomment-748482143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJV4IOUDERYJRJAFBRDSVS2J3ANCNFSM4Q4UKA2Q .

MysterAitch commented 3 years ago

PR has been merged - presumably this issue can be closed? Or is there more to come? :)

ghost commented 3 years ago

This doesn't seem to work if you only want to run it manually, and not on milestone closure as well...

I get the following error:

Getting Action Information
Milestone number is missing. Was the action raised by a milestone event?

ghost commented 3 years ago

I get the same issue as @BWPanda . I did docker pull decathlon/release-notes-generator-action:latest and confirmed that the necessary code changes have not been applied and there's also no 3.1.0 tag on Docker Hub Just waiting for release I guess.

ghost commented 3 years ago

Never mind. Looks like Docker Hub is out of date but what is published to the GitHub Actions Marketplace is up-to-date. I can use:

- name: Create Release Notes
   uses: Decathlon/release-notes-generator-action@v3.1.0

mmornati commented 3 years ago

Hey, guys sorry. I missed messages (too many notifications to follow every day). I will try to update Dockerhub as it seems it is the one not updated. But I thought the build and publish was automatic. @lusoalex can you confirm you configured everything to build the actions automatically.

Decathlon / release-notes-generator-action

Trigger manually? #14