bug: Add vertical padding for Snackbar component

ManonPolle commented 1 year ago

Describe the bug See https://github.com/Decathlon/vitamin-design/issues/90

Concerning

ManonPolle commented 1 year ago

Hello

If you still need this fix, yes you can take the issue and see our process & guidelines into our CONTRIBUTING.md https://github.com/Decathlon/vitamin-compose/blob/main/CONTRIBUTING.md, assign it to yourself & change issue status to Dev In Progress ( https://github.com/orgs/Decathlon/projects/3/views/14) Someone will check your Pull Request when created.

Don't hesitate if you have any questions

Manon, Tech lead Android Vitamin - Decathlon Design System

Le sam. 31 déc. 2022 à 17:36, Jeffrey Orazulike @.***> a écrit :

Can I take this issue?

— Reply to this email directly, view it on GitHub https://github.com/Decathlon/vitamin-compose/issues/55#issuecomment-1368249817, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEMANNV7OEQGK4C6WUNE5DWQBOILANCNFSM6AAAAAASX5WG5A . You are receiving this because you authored the thread.Message ID: @.***>

GerardPaligot commented 1 year ago

In Compose, there are hardcoded values for the padding of a Snackbar:

private val HorizontalSpacing = 16.dp
private val HorizontalSpacingButtonSide = 8.dp
private val SeparateButtonExtraY = 2.dp
private val SnackbarVerticalPadding = 6.dp

HorizontalSpacing is used for the padding at the beginning before the text and at the end.
HorizontalSpacingButtonSide is used for the padding between the text and the button if it exists.
SeparateButtonExtraY is used as bottom padding for the button if the snackbar have new lines.
SnackbarVerticalPadding is used as top and bottom paddings for the button if the snackbar is on one line.

These paddings are used in internal of the Snackbar and can't be customized.

Decathlon / vitamin-compose

bug: Add vertical padding for Snackbar component #55