Text under the icon on Button for the Navbar component

AlexNacache commented 1 year ago

Duplicates ❌

[X] I have searched the existing issues

Libraries

[X] Vitamin Web UI Kit
[ ] Vitamin Android UI Kit
[ ] Vitamin iOS UI Kit
[ ] Vitamin Icons
[ ] Vitamin Assets
[ ] Vitamin Core theme (Light mode)
[ ] Vitamin Core theme (Dark mode)
[ ] Vitamin Base colors palette
[ ] Vitamin Extras kit
[ ] Not related to one Figma library

Summary 💡

Be able to put the text of a button under the icon

Dependencies 📦

For the desktop navbar

Examples 🌈

Motivation 🔦

This allows us to use the "button" component

- [ ] https://github.com/Decathlon/vitamin-web/issues/1361

Sabrinavigil commented 1 year ago

Thanks, @AlexNacache, for the ticket :)

lauthieb commented 1 year ago

Hello,

I am writing to you because unfortunately, after investigating and starting to implement this on vitamin-web, I have to tell you that this change will cause big breaking changes and it seems complicated to me to integrate it as such.

Is it possible to keep the padding on the whole navbar as it was before? Indeed, here we can see that from now on when adding these buttons, we cancel the padding initially applied to the whole navbar. If I do the same thing, it will cause edge effects in all the applications currently consuming our v0.

So I would like to find this compromise to keep the padding on the whole navbar, please.

Also, is it possible to rename "_Bar utilities/Item button" to "_Bar utilities/Item link"? Finally, inconsistencies in the names of text variables, the layers are all called "Contact us" and yet the text displayed is not always "Contact us".

Thank you.

AlexNacache commented 1 year ago

Hello Laurent, Can we schedule a meeting so that you can explain to me what is wrong and your recommendations please? Thanks Alexandre

Le lun. 13 févr. 2023 à 17:08, Laurent Thiebault @.***> a écrit :

Hello,

I am writing to you because unfortunately, after investigating and starting to implement this on vitamin-web, I have to tell you that this change will cause big breaking changes and it seems complicated to me to integrate it as such.

Is it possible to keep the padding on the whole navbar as it was before? Indeed, here we can see that from now on, when adding these buttons, we cancel the padding initially applied to the whole navbar. If I do the same thing, it will cause edge effects in all the applications currently consuming our v0.

So I would like to find this compromise to keep the padding on the whole navbar please.

Also, is it possible to rename "_Bar utilities/Item button" to "_Bar utilities/Item link"? Finally, inconsistencies in the names of text variables, the layers are all called "Contact us" and yet the text displayed is not always "Contact us".

Thank you.

— Reply to this email directly, view it on GitHub https://github.com/Decathlon/vitamin-design/issues/158#issuecomment-1428210767, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5DRIHWWGMJHCPELHSHTCELWXJMBHANCNFSM6AAAAAATTE63DM . You are receiving this because you were mentioned.Message ID: @.***>

lauthieb commented 1 year ago

Hello @AlexNacache, thanks for your reply. I've seen this with @Decathlon/design-system-core-team-design and now it is merged on vitamin-web :) https://github.com/Decathlon/vitamin-web/pull/1372

Decathlon / vitamin-design