Decathlon / vitamin-design

Decathlon Design System - Design workflow management
https://decathlon.design
Apache License 2.0
34 stars 6 forks source link

Broken overrides of the price component #194

Closed VictorFF-Spain closed 1 year ago

VictorFF-Spain commented 1 year ago

Duplicates ❌

Libraries

Current behavior 😯

We have noticed that the alert variant in the price component has a name that breaks the override when we change the data. If you can see the screenshot, you will notice the name of the element is different.

Expected behavior 🤔

Once the data is modified, if we change the variant, we must keep the same data.

Context 🔦

No response

Screenshots / Videos 📸

image

SimonLeclercq commented 1 year ago

@MARIEDELATTRE rename layer name won't be breaking?

MARIEDELATTRE commented 1 year ago

I made a test it's not breaking