Decathlon / vitamin-design

Decathlon Design System - Design workflow management
https://decathlon.design
Apache License 2.0
34 stars 6 forks source link

Icon override on buttons jumps when we change variant #203

Closed MARIEDELATTRE closed 1 year ago

MARIEDELATTRE commented 1 year ago

Duplicates ❌

Libraries

Current behavior 😯

On a medium button with left icon variant (that have been changed) when I switch to small variant the icon is going back the default one.

Expected behavior 🤔

If think this can be fixed by adding instance swap property

Context 🔦

No response

Screenshots / Videos 📸

No response

MARIEDELATTRE commented 1 year ago

I've added swap instance component propertie on construction components. I've checked if it's breaking on left icon it seem to not be breaking regarding this video

https://user-images.githubusercontent.com/61324309/233650449-6d2e7175-54bf-4245-ac88-6445635b4db1.mp4

Image

MARIEDELATTRE commented 1 year ago

And its also ok for icon alone component

https://user-images.githubusercontent.com/61324309/233652784-5b817401-1425-455a-93be-1a114593f6e1.mp4

Image

MARIEDELATTRE commented 1 year ago

See test results here https://www.figma.com/file/HRY4QFI9yxroMHnjvQkdxk/Test-mockups-buttons?node-id=0%3A1&mode=design&t=6oVjFYFMod0RRXUE-1

Sabrinavigil commented 1 year ago

merged 🥳