Add a variant that works with background secondary for Skeleton component - Githubissues

Decathlon / vitamin-design

Decathlon Design System - Design workflow management

https://decathlon.design

Apache License 2.0

34 stars 6 forks source link

Add a variant that works with background secondary for Skeleton component #26

Closed Sabrinavigil closed 1 year ago

Sabrinavigil commented 2 years ago

Duplicates ❌

[X] I have searched the existing issues

Which Figma library is concerned?

Not related to one Figma library

Summary 💡

Add a skeleton variation for background secondary

Examples 🌈

No response

Motivation 🔦

No response

New 🆕

[ ] Validated in a grooming session

Backlog 📋

[ ] Has a good summary
[ ] Has example link(s)

Design in progress 🏗

[ ] Analysis (functional & technical)
[ ] Design refinement
[ ] Dev qualification (properties, breakpoints, tokens etc.)
[ ] Documentation refinement (inside the Figma branch)

Design review 👀

[ ] Figma branch merged
[ ] Documentation review _(and move the documentation into Vitamin Documentation Figma file)

Ready to dev 👍

[ ] Issues are created in all repositories affected (vitamin-<web,android,ios,compose>)

Dev in progress 💻

[ ] All issues are resolved (to replace with issues links)

Sabrinavigil commented 1 year ago

The background is tertiary on the Figma design, so it is a darker shade. Is this a problem in the code?

lauthieb commented 1 year ago

It's also tertiary in vitamin-web as you can see here in live: https://decathlon.github.io/vitamin-web/@vtmn/showcase-css/?path=/story/components-structure-skeleton--overview & here is the related source code: https://github.com/Decathlon/vitamin-web/blob/5ca93a7dadb60c96f401c04292ca56f25a4afd4e/packages/sources/css/src/components/structure/skeleton/src/index.css#L11