Decathlon / vitamin-design

Decathlon Design System - Design workflow management
https://decathlon.design
Apache License 2.0
34 stars 6 forks source link

Button component #7

Closed Sabrinavigil closed 1 year ago

Sabrinavigil commented 2 years ago

Duplicates ❌

Which Figma library is concerned?

Not related to one Figma library

Summary πŸ’‘

Improve button with properties and tokens. Add a "is loading" variation. Rework paddings on β€œwith icon” variant (make it pixel, perfect). Add missing reversed variation.

Examples 🌈

https://www.figma.com/community/file/1117085093344345579 https://www.figma.com/community/file/1115858697474114875 https://www.figma.com/community/file/1111717810979847533

Motivation πŸ”¦

No response

New πŸ†•

Backlog πŸ“‹

Design in progress πŸ—

Design review πŸ‘€

Ready to dev πŸ‘

Dev in progress πŸ’»

MARIEDELATTRE commented 2 years ago
MARIEDELATTRE commented 2 years ago

DONE:

TODO:

Sabrinavigil commented 2 years ago

DONE:

  • Component properties added.
  • Emoji in layers names.

TODO:

  • Doc in files (with plugin prop stars cf Vitamin - Improvements V0 & V1).
  • Add icon button component (not a variant, it's component itself).
  • Add a "is loading" variation.
  • Rework paddings on β€œwith icon” variant (make it pixel, perfect).
  • Add missing reversed variation.
Sabrinavigil commented 2 years ago

Add a circular variation : Image

Sabrinavigil commented 2 years ago

Add a critical button : Image Thanks @Tlahey :)

Sabrinavigil commented 2 years ago

An other use case of the circular button from @LoicVeira image

lauthieb commented 1 year ago

This topic has been launched. However, its status in the board no longer reflects the current reality, so it has been moved to our "New" column. We will wait for design tokens before. We will keep you informed of the different advances. Thank you.

lauthieb commented 1 year ago

Hello, As @Z08MURBE proposed, we will also need to take care about adding a loading state for the button that could be useful. Cf. this issue: https://github.com/Decathlon/vitamin-design/issues/186 Thank you again @Z08MURBE for your proposition. Laurent