Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
48 stars 14 forks source link

feat: UIKit badge size #108

Closed daniel-dumortier closed 1 year ago

daniel-dumortier commented 1 year ago

Changes description

To align badges between UIKit and SwiftUI, I added the size attribute to UIKit badges.

Context

Te aim is to align swiftUI and UIKit badges

Checklist

Does this introduce a breaking change?

Screenshots

iPhone

Simulator Screen Shot - iPhone SE (3rd generation) - 2023-03-03 at 16 51 08 Simulator Screen Shot - iPhone 8 - 2022-12-29 at 23 23 47 Simulator Screen Shot - iPhone 8 - 2022-12-29 at 23 24 36 Simulator Screen Shot - iPhone 8 - 2022-12-29 at 23 24 37 Simulator Screen Shot - iPhone 8 - 2022-12-29 at 23 24 34 Simulator Screen Shot - iPhone 8 - 2022-12-29 at 23 24 27 Simulator Screen Shot - iPhone 8 - 2022-12-29 at 23 24 07

iPad

Other information

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

daniel-dumortier commented 1 year ago

@SimonLeclercq Indeed, there was a border, but its color was too light (borderSecondary instead of borderPrimary) Since it is common code, it fixes the same bug on SwiftUI version of badge

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication