Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
48 stars 14 forks source link

fix: set tintAdjustmentMode to .normal #125

Closed JohannSzck closed 1 year ago

JohannSzck commented 1 year ago

Changes description

Add and set tintAdjustmentMode property to .normal for the imageView of VitaminButton

Context

The image tint color is changing when a UIAlertController is presented. Setting tintAdjustmentMode to .normal fix this problem.

You can see the change in the before/after provided in the screenshots section of this PR.

Checklist

Does this introduce a breaking change?

Screenshots

iPhone

As you can see below the tint color of the icon stay the same with an AlertController presented.

Before After
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication