Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
48 stars 14 forks source link

feat: Dynamic Vitamix Image Asset #129

Open SayadiMohamedOmar opened 1 year ago

SayadiMohamedOmar commented 1 year ago

The purpose of this issue is to give access to the app who is using Vitamix Asset to fetch the assets based on the name of the image so we can use them based on the configuration which will be provided by our app.

Example: the method provided by vitamin for fetching country by region code. public static func flag(countryCode: String) -> VitaminAsset?

florentlotthepro commented 1 year ago

Hello @SayadiMohamedOmar, Thanks for your improvement request.

Can you give us more information about how you imagine the naming? Country flags are a little different because a country code is a worldwide naming convention, there is no naming like that for icons.

Do we agree on something like the name of the icon on Figma with -fill or -line suffix? (Ex: home-fill and home-line)

SayadiMohamedOmar commented 1 year ago

Hello @florentlotthepro
yes i think it will be great if we use the icon name of Figma like you mentioned πŸ™πŸΎπŸ‘ŒπŸΏ

florentlotthepro commented 1 year ago

Hello @mackoj, What is your opinion on that?

mackoj commented 1 year ago

I think it's a great idea.

mackoj commented 1 year ago

I will add it to my ticket for the next major version of vitamin.