Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
48 stars 14 forks source link

refactor: update TextStyle component to prepare next components #34

Closed florentlotthepro closed 2 years ago

florentlotthepro commented 2 years ago

Changes description

Refacto TextStyle to expose more easily the needed informations like font or size. This is needed to start SwiftUI version of the TextStyle to avoid duplications.
This PR also fix a line height issue with large accessibility font size.

Context

In some case when need to access to some informations like font or size and it was currently not easy.

Checklist

Does this introduce a breaking change?

Screenshots

iPhone

No changes on the UI, big changes in code.

Before After
Before_1 After_1
Before_2 After_2
Before_3 After_3
Issue_before Issue_after

🧑‍💻 Developer notes

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication