fix: proposal for accessibility of progress bar

FannyDemey commented 2 years ago

Changes description

This PR contain improvement of progress bar accessibility. They might be some optimization to do for example :

How to copy localized string of standard UIProgressView (not sure how to do it with Swift)

Context

Progress bar was not accessible with voiceover, meaning that if a blind user encounter a Progress there were no focus on this element so the user has no idea of what's going on. What I have done is :

Letting end user add custom accessibilityLabel for exemple "Loading new products in progress".
announcing percentage update in accessibilityValue
If no custom accessibilityLabel, setting UIProgressView default accessibilityLabel

What could be improved :

swift syntax probably as it is not my main language.
add an animated progress bar in Showcase to validate that value is well announced with VoiceOver when percentage change

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[x] If it includes design changes, please ask for a review with a core team designer.