feat: add tag component

daniel-dumortier commented 2 years ago

Changes description

Add the Tag component implementation

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[ ] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[ ] If it includes design changes, please ask for a review with a core team designer.

No the backgroundDiscount color has been replaced by the backgroundAlert color. But the backgroundDiscount has been kept, with a deprecation message

Simulator Screen Shot - iPhone 8 - 2022-03-10 at 20 58 10

Simulator Screen Shot - iPad Air (4th generation) - 2022-03-10 at 21 02 00

daniel-dumortier commented 2 years ago

I pushed some fixes :

vertical alignment (which indeed was not the same with and without icon)
typos in comments (I should really re-read myself before commiting ;) )
extraction of variant in its own type (not a inner type of VitaminTag anymore) for further usage with SwiftUI
handling of color change when switching dark and light mode
adding of deprecated backgroundDiscount color to avoid breaking change