feat: Adding Decorative + Shadow Colors / Fix Background.discount

Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications

https://www.decathlon.design

Apache License 2.0

48 stars 14 forks source link

feat: Adding Decorative + Shadow Colors / Fix Background.discount #55

Closed baptistedajon closed 2 years ago

baptistedajon commented 2 years ago

Changes description

Adding Decorative + Shadow Colors / Fix Background.discount

Context

Needed new colors for my project

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.

Does this introduce a breaking change?

CLAassistant commented 2 years ago

All committers have signed the CLA.

lauthieb commented 2 years ago

@baptistedajon feel free to fix conflicts. Can you please take this opportunity by taking this issue: https://github.com/Decathlon/vitamin-ios/issues/23? Thanks

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

daniel-dumortier commented 2 years ago

@lauthieb : I made the last changes, resolved the conflicts, and integrated the missing refacto from #23 (some of them had already been integrated before) I also linked the corresponding issues to this PR

Whenever @florentlotthepro or @baptistedajon approves, I will be able to merge it

@florentlotthepro : I did not write any new comment, there should be no typos this time ;)