Closed daniel-dumortier closed 2 years ago
I decided to commit an intermediate solution for the problem of reusing VitaminButtonIconType
:
IconType
enum for swiftUI, that can still have an UIImage
associated value, but a Image.TemplateRenderingMode
(and not a UIImage.RenderingMode
anymore)IconType
has an internal computed property of type VitaminButtonIconType
With this approach, I think we combine two advantages :
IconType
are more "swiftUI" (even if it still uses UIImage
, but after all, Vitamix
also deals with UIImage
)VitaminButtonIconType
can be reused for swiftUIAny feedbacks on this approach (and if it is better than the previous) are welcome ;)
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Changes description
this PR aims to provide a Swift UI implementation for VitaminButton. It is still in draft, because some points are to be finalized or discussed
Context
related issue still to be created
Checklist
Does this introduce a breaking change?
Screenshots
I will add screenshots when finalized
iPhone
iPad
Other information
For now, the base branch is the UIKit VitaminButton icon alone branch, will change to develop once validated and merged