Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
48 stars 14 forks source link

feat(button): VitaminButton swiftUI implementation #76

Closed daniel-dumortier closed 2 years ago

daniel-dumortier commented 2 years ago

Changes description

this PR aims to provide a Swift UI implementation for VitaminButton. It is still in draft, because some points are to be finalized or discussed

Context

related issue still to be created

Checklist

Does this introduce a breaking change?

Screenshots

I will add screenshots when finalized

iPhone

iPad

Other information

For now, the base branch is the UIKit VitaminButton icon alone branch, will change to develop once validated and merged

daniel-dumortier commented 2 years ago

I decided to commit an intermediate solution for the problem of reusing VitaminButtonIconType :

With this approach, I think we combine two advantages :

Any feedbacks on this approach (and if it is better than the previous) are welcome ;)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication