search

Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
279 stars 77 forks source link

refactor(@vtmn/css): select & dropdown components #1020

Closed crotru closed 1 year ago

crotru commented 2 years ago

Is your request related to a problem? Please describe. Select & dropdown components was built based on beta design.

Describe the solution you'd like It needs a refactor and its code needs to be aligned with the input component. A proposition was made in #951, unfortunately it introduces breaking change and can't be merged before v1 release

Some of needed changes :

Actually most of those could be handled without dom changements ⚠️ When addressed, all those have to be aligned between both input and select

Check said PR for more details and code proposition

Related issues:

lauthieb commented 2 years ago

Thanks a lot for this issue @crotru. As discussed together with @GaspardMathon, we propose you to address it when we will begin the Version 1 of Vitamin. That's why I've added the "v1" label. Have a nice day :)

GaspardMathon commented 2 years ago

I disagree for the removing of the line-height on the label as it creates a difference between design and dev.

lauthieb commented 1 year ago

Fyi, remark and details from @Tlahey here: https://github.com/Decathlon/vitamin-web/issues/1412

lauthieb commented 1 year ago

Fyi, remark and details from @MaelthiS here: https://github.com/Decathlon/vitamin-web/issues/1303

lauthieb commented 1 year ago

Fyi, remark and details from @0x2A-git here: https://github.com/Decathlon/vitamin-web/issues/1402

stale[bot] commented 1 year ago

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reopen whenever you want. Thank you for your contributions.