Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
282 stars 76 forks source link

feat(@vtmn/svelte): Hash output bundle #1367

Closed Tlahey closed 1 year ago

Tlahey commented 1 year ago
image

Today the vtmn bundle are published without hashed files. So we have to think about enhancer the build process to add hash on the index.css file.

2 solutions :

thibault-mahe commented 1 year ago

Thanks for opening this issue @Tlahey! 2 quick questions to discuss:

Tlahey commented 1 year ago

I don't have the view at the moment. I think I need to POC this with NFS configuration. But yes, all other packages on the bundle should be hashed (without the index.css -> Its the own of the consumer to hash this file)

lauthieb commented 1 year ago

Thanks @Tlahey for your answer. Feel free if you need help form us or @Decathlon/design-system-core-contrib-web-dev

lauthieb commented 1 year ago

Hi @Tlahey, As discussed with @thibault-mahe this morning, we took the decision to concentrate our effort regarding the build task (and your proposition for hashing output bundle" with our new version that we currently build inner source (thanks again btw for your contribution on this build topic!). That's why I close it. Thanks for your understanding.