Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
282 stars 76 forks source link

fix(@vtmn/react): add missing onChange event to `VtmnDropdown` #1380

Closed 0x2A-git closed 1 year ago

0x2A-git commented 1 year ago

Changes description

Injected new event in VtmnDropdown's children and then called children's callback. This event was missing according to the showcase : https://www.decathlon.design/726f8c765/v/0/p/42d824-dropdown/b/28931f

Context

This P.R aims to resolve issue #1377 by adding an onChange event to VtmnDropdown component.

Checklist

Does this introduce a breaking change?

Other information

0x2A-git commented 1 year ago

Thanks! Now that's ok for me. @Decathlon/design-system-core-contrib-web-dev can you please review?

Nice ! Thanks for having pointed out this issue I didn't notice it when testing it :S

Good afternoon :D