search

Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
282 stars 76 forks source link

docs: typeface is now deprecated #1426

Closed jquinc30 closed 1 year ago

jquinc30 commented 1 year ago

The @vtmn/css readme in install-fonts paragraph refer to the npm package typeface-roboto which is now deprecated:

image

The suggested replacement is FontSource so we should update our readme.

I also suggest to reorder paragraph around fonts to put npm package solution at the first proposed solution because local fonts brings many advantages, especially for web performance 🚀

And add a tip for font subsetting, via fontsource for example, could also help our consumer to get performance improvement.

lauthieb commented 1 year ago

Hi @jquinc30, Thank you very much for this very useful and rich information that will allow us to improve our doc! I find that all this would be very coherent and so I leave the ticket open for contribution. Would you volunteer to create the associated Pull Request?

lauthieb commented 1 year ago

Hi @jquinc30, Here is my PR: https://github.com/Decathlon/vitamin-web/pull/1442 Thanks :)

thibault-mahe commented 1 year ago

Thanks @lauthieb ! @jquinc30 is this PR ok for you ? :) I'll merge it as is today! Thanks again