Closed Martin-Brandenburg closed 1 year ago
Thanks @Martin-Brandenburg for this proposition! I'll let @thibault-mahe review it. @Tlahey feel free to check it out also if you can, please 🙏. @Martin-Brandenburg can you please sign the CLA? https://github.com/Decathlon/vitamin-web/pull/1461#issuecomment-1719618856
Changes description
This is a bugfix to the VtmnAccordion component. The
open
prop was binded in the details element.Context
The previous implementation only allows us to pass the
open
prop down, but changes are not reflected. In particular, we cannot let the parent of the VtmnAccordion know when it is open and when not. So this is just a missing feature, but: there is also a bug in the previous implementation: the linearia-expanded={open}
means that thearia-expanded
property is always set to the initial value. It will never be changed.When the accordion is closed, it does not have the
open
prop and we havearia-expanded=false
, which is correct:But when it is opened, the
open
prop is added, butaria-expanded=false
stays.This pull request fixes this bug.
Checklist
design-system-core-team-design
GitHub team.Does this introduce a breaking change?