fix(@VtmnReact): allow badge component to have 0 as a value

romuleald commented 1 year ago

Changes description

Badge doesn't accept 0 as a value, but instead it's showing an empty string

Context

It should accept 0 as a value as fixed here

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[ ] I have tested on related showcases.
[ ] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

Yes
No

Other information

Tlahey commented 1 year ago

Hello @romuleald thanks for your PR. But as the DS website says https://www.decathlon.design/726f8c765/p/465f7c-badge/b/587b7e The display 0 should not be exist.

If you really wan't to display 0, you can do a workaround on your side and set it as a string.

thibault-mahe commented 1 year ago

Hi @romuleald, thank you for suggesting this PR.

We've checked with the designers and, as @Tlahey also points out in his comment, this choice is indeed a documented design decision.

Given current priorities and our resources, there are no plans to change this behavior on this version of Vitamin. On the other hand, we're taking good note of it so that we can take it into account in the new version we're currently working on.

I'm therefore closing this PR, but do note we're very grateful for the time you spent suggesting this code.

Thanks!

Decathlon / vitamin-web