Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
282 stars 76 forks source link

feat(@vtmn/css, @vtmn/react, @vtmn/svelte, @vtmn/vue): Improve `VtmnAlert` component #1463

Closed ThomasPierreDECATH closed 1 year ago

ThomasPierreDECATH commented 1 year ago

Describe the bug We want to use the Alert component into a page but not sticky. In order to to that we need to import VtmnAlertItem but it is not exported for the moment

This component could be impoved by :

Tlahey commented 1 year ago

I take it Also set 2 slots (like the VtmnAccordion)

Tlahey commented 1 year ago

ping @lauthieb it seems ok for you ? No breaking changes

lauthieb commented 1 year ago

Thanks @ThomasPierreDECATH for your issue & @Tlahey for your answer. @Tlahey I'll let you check directly with @thibault-mahe for confirmation, but if there are no breaking changes, it could be okay yes :)

Tlahey commented 1 year ago

Linked PR https://github.com/Decathlon/vitamin-web/pull/1464

Tlahey commented 1 year ago

For informations

Tlahey commented 1 year ago

We can close this issue