Closed Tlahey closed 1 year ago
hi! thanks for this PR @Tlahey and for pinging me @lauthieb . Everything is ok for me here, the use of the slot is nice and allows the component to be more flexible, without bringing any breaking change. The only mini breaking change is that the aria-label of the close button is no longer set to "Close toast" by default, which you can quickly change if you want @Tlahey.
Okay fo me otherwise.
Hello @thibault-mahe I've done the fix on the aria-label ;)
Changes description
Svelte part :
<p>
to<span>
in order to be ISO with other frameworksSvelte / React / Vue :
id
no really necessaryAlso checked https://www.w3.org/WAI/ARIA/apg/patterns/alertdialog/examples/alertdialog/ The div with a role alert doesn't need to have a aria-labelledby /describeby
Context
Checklist
design-system-core-team-design
GitHub team.Does this introduce a breaking change?
Other information