Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
282 stars 76 forks source link

feat(`@vtmn/svelte`, `@vtmn/react`, `vtmn/vue`): use `VtmnAlert` as a component #1464

Closed Tlahey closed 1 year ago

Tlahey commented 1 year ago

Changes description

image

Svelte part :

Svelte / React / Vue :

Also checked https://www.w3.org/WAI/ARIA/apg/patterns/alertdialog/examples/alertdialog/ The div with a role alert doesn't need to have a aria-labelledby /describeby image

Context

Checklist

Does this introduce a breaking change?

Other information

thibault-mahe commented 1 year ago

hi! thanks for this PR @Tlahey and for pinging me @lauthieb . Everything is ok for me here, the use of the slot is nice and allows the component to be more flexible, without bringing any breaking change. The only mini breaking change is that the aria-label of the close button is no longer set to "Close toast" by default, which you can quickly change if you want @Tlahey.

Okay fo me otherwise.

Tlahey commented 1 year ago

Hello @thibault-mahe I've done the fix on the aria-label ;)