DecaturMakers / dm-vvv-configs

The Decatur Makers VVV configurations files
0 stars 0 forks source link

VVV init script is unable to clone private git repos #1

Open aquillano opened 8 years ago

aquillano commented 8 years ago

This is specifically a problem for us when trying to clone our decaturmakers.org repo. It happens because the vagrant provisioning process runs as root and doesn't have access to a forwarded SSH agent (During vagrant ssh, SSH agent forwarding does work, but that doesn't help us here). I have two solutions to the problem and thought this would be a good place to discuss, debate and decide on which solution we'd like to use.

Pros Cons
Everything remains encapsulated in this single vvv-init.sh script There is an extra initial step of having to generate a personal access token
Pros Cons
Ideally, the initialization of the dev enviroment is a single command: make Can't really thing of any cons
lewlefton commented 8 years ago

I don't have a strong preference for either solution. I'm comfortable with both options. Creating a personal access token on github.com may potentially have additional benefits later but it will be an additional (one-time) step for newbies, too. A Makefile provides potentially more customization down the road but is a more traditional approach and may require installation of CLI dev tools (autoconf, etc?).

I'd say flip a coin or just choose one if there aren't any more opinions in the next day or so.

aquillano commented 8 years ago

To your point, instead of using make, we could just use a new setup.sh script to kick things off.