search

DecentSoftware-eu / DecentHolograms

A lightweight but powerful hologram plugin with many features and configuration options.
https://www.spigotmc.org/resources/96927/
GNU General Public License v3.0
211 stars 101 forks source link

Folia support with bukkit #175

Closed mani1232 closed 9 months ago

mani1232 commented 11 months ago

Test jar file: DecentHolograms-2.8.5-all.zip

d0by1 commented 11 months ago

Hello, thanks for the PR. I have a couple problems with it though.

First of all, there are too many changes. This PR is supposed to just implement support for Folia. All the refactoring, formatting and other changes are unnecessary and I will not be merging them. Also, you changed the version of Gradle and the ShadowJar plugin. It was on an older version for a reason and changing it would break things.

Another problem I have with this is the way you only use the FoliaLib's methods to schedule tasks. Basically, I don't see any proper backwards compatibility with Bukkit or Spigot. The library might handle that but I'd still like to see different implementations for a common Scheduler interface, that would contain all the required methods. This way, we could just initialize a Scheduler on startup, based on the server type, and use that to schedule everything.

Now, I'd understand if you didn't want to do all this. If you do want to take this on, let me know, otherwise I will do it myself.