DecentSoftware-eu / DecentHolograms

A lightweight but powerful hologram plugin with many features and configuration options.
https://www.spigotmc.org/resources/96927/
GNU General Public License v3.0
183 stars 83 forks source link

DecentHolograms incompatible with future Paper versions #186

Closed kennytv closed 1 month ago

kennytv commented 5 months ago

Just making sure

Reproduction

Run https://github.com/PaperMC/testing/releases/tag/no-relocation, start with DecentHolograms

Solution

See https://forums.papermc.io/threads/paper-velocity-1-20-4.998/#post-2955

Server Version

1.20.4

Client Version

1.20.4

Plugin Version

2.8.6

Log

https://paste.gg/p/anonymous/4ea996af04484343b25fc55ba1c368e5

Andre601 commented 5 months ago

Looking at the code, the only problem I can see is updating the Version class... This could be relatively simple, but may require to find out every possible output of Bukkit.getServer().getBukkitVersion() down to 1.8 to create proper changes to use as it seems to be a get package name -> check with enum of version patterns thing used here.

Perhaps getting the Bukkit version, doing some string transformations (i.e. split at - and use first part and replace dots with _) could already go a long way here... But again would we need to know all versions that the plugin should support and their respecive Bukkit version output... :/

chxseh commented 2 months ago

Seems they've pulled the trigger on this.

https://forums.papermc.io/threads/important-dev-psa-future-removal-of-cb-package-relocation.1106/

Looks like the affected line is https://github.com/DecentSoftware-eu/DecentHolograms/blob/e6ac39a4a0d1644e3c724dd7f94f1106196e04a7/src/main/java/eu/decentsoftware/holograms/api/utils/reflect/ReflectionUtil.java#L90

d0by1 commented 1 month ago

Hello, a workaround has been implemented in version 2.8.7. Thank you for letting us know about this!