DecentSoftware-eu / DecentHolograms

A lightweight but powerful hologram plugin with many features and configuration options.
https://www.spigotmc.org/resources/96927/
GNU General Public License v3.0
212 stars 100 forks source link

player Skull wont load if the player is not in the server #230

Open Hiradpi opened 3 months ago

Hiradpi commented 3 months ago

Just making sure

Reproduction

Im trying to put the top first player's skull with the most kills in the hologram but it only loads the head when they are in the server - content: '#SMALLHEAD: skull_item:3 : (playername)' when the player is present it loads the head but when is not it loads alex or steve my server is offline (cracked) the players that im testing this with are not cracked ( server is on 1.8 and im using via ) i even tried to create a papi extension that turns player names to skin textures but it was harder that i imagined

Solution

No response

Server Version

1.8

Client Version

1.20.4,1.8.9,1.21

Plugin Version

v2.8.8

Log

does not need one in this case i guess

Andre601 commented 3 months ago

You answered your own problem: Your server is in offline-mode.

Offline-mode servers famously do not show player skins, due to them not validating player names to be actual valid ones. Given this fact, the server simply doesn't obtain the necessary player data for the head to display. The fact you have skins shown is most likely due to you using SkinRestorer, which afaik does do calls to the Mojang Auth APIs to obtain skin data, updating/modifying the player data on the server.

Do yourself a favour and run a legit server and not cracked. Supporting piracy in MC is not a good thing.

Hiradpi commented 3 months ago

we are not supporting piracy in fact as i said me and my friends have legit minecraft accounts but due to our country's restrictions some people are not able to buy minecraft account a plugin as big as DH should have support for offline mode servers or at least use SkinRestorer's api or just try to get the skin behind the username for example if i enter d0by's name it should be able to get the texture and set the skull to d0by's skull similar to essential's /skull command or citizen's npc skin name
thanks for your time <3

Andre601 commented 3 months ago

Just because a plugin is fairly popular doesn't mean it has to support any possible use-case there is. That is a faulty expectation you shouldn't have here.

I for my part cannot see a justifiable reason for cracked servers. Yes, it sucks some can't purchase MC to play, yet that is still not a reason to just go pirating it, let alone allowing people with such accounts to join a server. The fact you have a valid account tells me that there is some way to obtain such accounts, even if it is limited.

But that is my view here.

Either way, if you want such support, add it yourself. The plugin is open source after all, so you can simply implement it yourself. I personally can't see d0by adding this at all tho, as there simply isn't any good reason to do so and plugins shouldn't encourage nor support pirated accounts on any level (Again, my view here).

BakiDance commented 2 months ago

I'm adding my report from Discord here, as this seems to be the most relevant issue. I can make a new issue, however, if required.

My server (Paper-496 1.21 running DH 2.8.9) is offline-mode, but behind an online-mode proxy. In no way is my server "cracked", yet I'm affected by this bug. This is the only plugin I am using that seems unable to gather skins for offline players. DeluxeMenus, for instance, has no issue.

If my server were fully in offline/cracked I'd understand, but the plugin should still be able to gather offline skins in online mode, should it not?

GrimPlayzs commented 1 month ago

I also have this issue when the server is in offline mode. HOWEVER, I have to run the servers in offline mode because I run a velocity network, which is in online mode.