search

DecentSoftware-eu / DecentHolograms

A lightweight but powerful hologram plugin with many features and configuration options.
https://www.spigotmc.org/resources/96927/
GNU General Public License v3.0
211 stars 101 forks source link

Fix resolvable profile error for setting/getting textures. #245

Closed Olzie-12 closed 2 weeks ago

Olzie-12 commented 2 months ago

I've created a fix for the new commit that Spigot has made here that changes the CraftMetaSkull class to use a new component ResolveableProfile, that prevented from setting/getting textures due to this change.

Olzie-12 commented 2 months ago

Here is the compiled jar file, this has not been tested yet. Please let me know how you get along with it. DecentHolograms-2.8.11.zip

TH3N3WN00B commented 2 months ago

Just tested it

[00:34:07] [Server thread/INFO]: [DecentHolograms] Enabling DecentHolograms v2.8.11 [00:34:07] [Server thread/ERROR]: Error occurred while enabling DecentHolograms v2.8.11 (Is it up to date?) java.lang.IllegalStateException: DecentHolograms is not running (yet). Do you have DecentHolograms plugin installed? at DecentHolograms-2.8.11.jar/eu.decentsoftware.holograms.api.DecentHologramsAPI.get(DecentHologramsAPI.java:96) ~[DecentHolograms-2.8.11.jar:?] at DecentHolograms-2.8.11.jar/eu.decentsoftware.holograms.plugin.DecentHologramsPlugin.onEnable(DecentHologramsPlugin.java:40) ~[DecentHolograms-2.8.11.jar:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?] at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:654) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:603) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:758) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:520) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:366) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1231) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:334) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?] [00:34:07] [Server thread/INFO]: [DecentHolograms] Disabling DecentHolograms v2.8.11

Olzie-12 commented 2 months ago

DecentHolograms-2.8.11.zip My fault! Uploaded the wrong jar.

TH3N3WN00B commented 2 months ago

DecentHolograms-2.8.11.zip My fault! Uploaded the wrong jar.

That one worked fine!! thanks

Olzie-12 commented 1 month ago

Here's a new fix to people getting a NPE with skulls that's got no texture. DecentHolograms-2.8.12.zip