MiniMessage Support - Githubissues

DecentSoftware-eu / DecentHolograms

A lightweight but powerful hologram plugin with many features and configuration options.

https://www.spigotmc.org/resources/96927/

GNU General Public License v3.0

211 stars 101 forks source link

MiniMessage Support #90

Open zax71 opened 1 year ago

zax71 commented 1 year ago

Just making sure

[X] I have read the wiki and made sure, this feature is not yet in the plugin.
[X] I believe, that this feature is possible to implement.
[X] I made sure, that this feature has not been requested yet.

Problem

Some plugins only support MiniMessage text and will not work with the legacy colour code system. Due to this, some PlaceholderAPI placeholders have been modified for MiniMessage and cannot be used in Holograms.

Feature

I'd love DecentHolograms to follow suit with other plugins and switch to Adventure and MiniMessage (Or even just MiniMessage using serialisers)

Alternatives

The only other alternative for my unique case would be asking the other plugin to support legacy colour codes, but looking at the broader picture, MiniMessage is a lot more human-readable and widely adopted already, so would greatly improve the user's experience if you added support.

Andre601 commented 1 year ago

This is already planned for v3 of DH which is in the making.

DaRacci commented 1 year ago

This is already planned for v3 of DH which is in the making.

Is there a branch with this progress or is it in need of any extra help for minimessage support, I've worked with and added support to quite a few plugins and would love to get minimessage working for holograms

Zoltus commented 1 year ago

any news?

mudkipdev commented 8 months ago

bump?

Andre601 commented 8 months ago

Bumping this won't make it be implemented any faster. If you want it, PR the change yourself.

mrdeniska1234 commented 3 months ago

MiniMessage support need

Recliness commented 3 months ago

This feature would be amazing! Looking forward to it soon.

Andre601 commented 3 months ago

d0by mentioned this to me once, that there is honestly no benefit of using MiniMessage here that can't be implemented in DecentHolograms itself through some own method. In fact, MiniMessage and Adventure would only add bloat for the most part as quite a few features aren't usable here:

No click actions are doable here, as not only do you not "click" any text here, but even if it was somehow added, would it be pretty difficult to know what line is selected here...
Hover actions have absolutely no use here as there is no way to display hover text or similar while looking at a line.

The only beneficial features are colors and formatting here (And the gradient pattern), which can be implemented directly instead of relying on some 3rd-party library...

That's at least the stuff I recall d0by mentioned to me, but it was a long while ago.

mrdeniska1234 commented 2 months ago

There is some sense in your words. In fact. There are just plugins that use the DecentHologram API, and while supporting minimessage, they try to display the minimessage format and encounter the fact that decenthologram itself shows bare markup. There are not many such plugins and they all support the legacy format, but still