search

DecentralCardGame / cardobject

cardobject-library written in go
3 stars 4 forks source link

Limit max. character numbers card names for 25 characters incl. spaces #71

Open AnnyBuh opened 2 years ago

AnnyBuh commented 12 months ago

Re-opening this as I am doing the design guidelines. Can we change the max. character numbers including spaces to 23? 25 is still too tightly squeezed.

Screenshot 2023-11-17 at 08 11 39 Screenshot 2023-11-17 at 08 11 31
patrickwieth commented 12 months ago

From our current alpha set, only 2 cards have more than 23 chars:

Time Manipulation Device image

Preserver of Lost Wisdom image

So we need to change those names. What I see here: For these 2 cards it is not problematic and 24 chars is ok. I think the reason why your example looks squeezed is because these numbers take up more space than an average distribution of letters. The numbers are more like capital letters and most used letters take up a bit less space like a,e,u,o and especially i.

So we have 3 options: a) leave 25 chars as it is only a problem with names like THE BIG CHUNKY MONSTER WITH LONG NAME AND CAPSLOCK b) change to 23, then we need to find new names for preserver of lost wisdom (can be changed to keeper easily) and Time Manipulation Device (not so easy, because other words like Apparatus, Gadget, Module are not really shorter). c) change to 24, we don't have to rename anything, we only have the trouble of updating the cardobject and deploying it

AnnyBuh commented 12 months ago

From a programming POV: Is it possible to not limit the exact number of characters, but the textbox in which the characters will be?

patrickwieth commented 12 months ago

Theoretically yes, but the problem is the cardobject has nothing todo with the svg textbox, maybe there is a mapping for the font how big letters are and we can use this in the cardobject. But the question is: Is it important enough for the amount of work?

nlsui commented 9 months ago

Answer: no. decide on a lenght and I will set it to that