search

DecentralCardGame / frontend

The frontend for Crowd Control
https://crowdcontrol.network
5 stars 4 forks source link

204 add more centralized approach to most used state #215

Closed lxgr-linux closed 1 year ago

lxgr-linux commented 1 year ago

Centralized coins and user

lxgr-linux commented 1 year ago

doing stuff like isXYModalVisible over state can sometimes be problematic: For example in some screen ratios the modal takes up a huge portion of the screen and the close button becomes unclickable, then going back and returning via browser leads to a situation where the modal is still there and might be problematic. I think in this case it might be not too dramatic, since your solution would allow to F5 the page and then get rid of the modal

Sadly, that's how we did all modals. Always. And I doubt, that other modals via routerlink are possible.

patrickwieth commented 1 year ago

It's not necessary to do it via routerlink. The variable can be page specific or be resetted when reloading the page.

lxgr-linux commented 1 year ago

That's exactly, what's happening